-
Notifications
You must be signed in to change notification settings - Fork 23
PBM-1588 Alibaba Cloud Storage support #309
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
modified: docs/css/design.css new file: docs/details/oss.md modified: docs/details/storage-configuration.md modified: docs/reference/configuration-options.md modified: mkdocs-base.yml
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds support for Alibaba Cloud Object Storage Service (OSS) as a backup storage option for Percona Backup for MongoDB (PBM). This enables users operating in Asia-Pacific regions or China to use Alibaba Cloud OSS for low-latency backup storage.
Key Changes:
- Added comprehensive documentation for Alibaba Cloud OSS storage configuration and usage
- Updated storage configuration references to include OSS as a supported storage type
- Fixed minor documentation formatting issues
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| docs/details/oss.md | New documentation page detailing Alibaba Cloud OSS setup, configuration, and encryption options |
| docs/reference/configuration-options.md | Added complete OSS storage configuration options and parameters |
| docs/details/storage-configuration.md | Updated to list OSS among supported storage types and reorganized content structure |
| docs/features/split-merge-backup.md | Added OSS maximum file size limit and fixed admonition syntax |
| mkdocs-base.yml | Added OSS documentation to navigation and updated color scheme references |
| docs/css/design.css | Updated CSS for color scheme names and added version select styling |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
lgtm for alicloud docs @nastena1606 |
boris-ilijic
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, see comments
| ```yaml | ||
| retryer: | ||
| maxAttempts: 5 | ||
| maxBackoff: 30 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
300s
| retryer: | ||
| maxAttempts: 5 | ||
| maxBackoff: 30 | ||
| baseDelay: 30 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
30ms
Provided values are default one, but let's suggest user to use units instead of raw numbers.
Co-authored-by: Sandra Romanchenko <53295797+sandraromanchenko@users.noreply.github.com>
modified: docs/css/design.css
new file: docs/details/oss.md
modified: docs/details/storage-configuration.md
modified: docs/reference/configuration-options.md
modified: mkdocs-base.yml
modified: docs/features/split-merge-backup.md